[jira] [Commented] (SVN-1778) [python] FileDiff broken on Windows

["Daniel Sahlberg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SVN-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770870#comment-17770870 ] 

Daniel Sahlberg commented on SVN-1778:
--------------------------------------

r1824410 added support for running the internal Subversion diff functions (svn.diff.file_diff_2 and svn.diff.file_output_unified4) as long as the argument diffoptions is None (the default). Since diffoptions is passed as arguments to the diff command, it seems reasonable to require the presence of diff (or diff.exe) if one uses diffoptions.

 

> [python] FileDiff broken on Windows
> -----------------------------------
>
>                 Key: SVN-1778
>                 URL: https://issues.apache.org/jira/browse/SVN-1778
>             Project: Subversion
>          Issue Type: Bug
>          Components: bindings_swig_python
>    Affects Versions: all
>         Environment: Windows 2000
>            Reporter: Subversion Importer
>            Priority: Critical
>             Fix For: unscheduled
>
>
> {noformat:nopanel=true}
> In function get_pipe, class FileDiff spawns a "diff" process, but usually no
> "diff.exe" executable is available under Windows, so the FileDiff class might be
> completely non-functional on most Win installation. Maybe using Python difflib
> calls could be a better solution.
> {noformat}
> Original issue reported by *iaanus*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)