You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/21 07:27:12 UTC
[GitHub] [incubator-doris] WingsGo opened a new issue #3362: [Bug]OlapTableSink.finalize may use a another method name to avoid GC thread execute?
WingsGo opened a new issue #3362:
URL: https://github.com/apache/incubator-doris/issues/3362
I found that in OlapTableSink.java, there is a function named `finalize`. In Java, it will be called when GC destory the object, but I found that it will cause OOM. Because if we not define `finalize` method, the object will be recycle imediatelly, but if we define it, the object will insert into `java.lang.ref.Finalizer.ReferenceQueue`, if we have large object in the queue, the fe will down cause by OOM.
https://github.com/apache/incubator-doris/blob/c6ac60bab9563a77b052a2766b0de859528aee41/fe/src/main/java/org/apache/doris/planner/OlapTableSink.java#L121-L137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on issue #3362: [Bug]OlapTableSink.finalize may use a another method name to avoid GC thread execute?
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on issue #3362:
URL: https://github.com/apache/incubator-doris/issues/3362#issuecomment-617080829
Good job!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org