You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/25 16:32:32 UTC

[GitHub] [superset] maloun96 commented on a change in pull request #12218: refactor(explore): Enhance Dataset and Control panel Collapse components

maloun96 commented on a change in pull request #12218:
URL: https://github.com/apache/superset/pull/12218#discussion_r563861835



##########
File path: superset-frontend/src/common/components/Collapse.tsx
##########
@@ -68,6 +90,18 @@ const Collapse = Object.assign(
         }
       }
     }
+    .ant-collapse-item-active {
+      .ant-collapse-header {
+        ${({ expandIconPosition }) =>
+          expandIconPosition &&
+          expandIconPosition === 'right' &&
+          `
+            .anticon.anticon-right.ant-collapse-arrow > svg {
+              transform: rotate(-90deg) !important;

Review comment:
       can we avoid using important?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org