You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/10 15:56:32 UTC
[GitHub] [spark] rdblue edited a comment on issue #24581: [SPARK-27675][SQL]
do not use MutableColumnarRow in ColumnarBatch
rdblue edited a comment on issue #24581: [SPARK-27675][SQL] do not use MutableColumnarRow in ColumnarBatch
URL: https://github.com/apache/spark/pull/24581#issuecomment-491339025
Overall, looks good to me (+1). One minor point about avoiding code duplication by extending the read-only row to add the write methods, but that's not a blocker for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org