[GitHub] [druid] mitchlloyd commented on issue #9319: Make Transform an ExtensionPoint

[GitBox <gi...@apache.org>]

mitchlloyd commented on issue #9319: Make Transform an ExtensionPoint
URL: https://github.com/apache/druid/pull/9319#issuecomment-584468534
 
 
   I’m happy to take at shot at more documentation in this PR. I should have a
   chance to revisit this week.
   
   On Mon, Feb 10, 2020 at 2:40 PM Jihoon Son <no...@github.com> wrote:
   
   > *@jihoonson* commented on this pull request.
   > ------------------------------
   >
   > In docs/development/modules.md
   > <https://github.com/apache/druid/pull/9319#discussion_r377360313>:
   >
   > > @@ -46,6 +46,7 @@ Druid's extensions leverage Guice in order to add things at runtime.  Basically,
   >  1. Add new Jersey resources by calling `Jerseys.addResource(binder, clazz)`.
   >  1. Add new Jetty filters by extending `org.apache.druid.server.initialization.jetty.ServletFilterHolder`.
   >  1. Add new secret providers by extending `org.apache.druid.metadata.PasswordProvider`.
   > +1. Add new ingest transform by implementing the `org.apache.druid.segment.transform.Transform` interface from the `druid-processing` package.
   >
   > It makes sense to me to add a new item in the list of 15 items under
   > "Writing your own extensions" for completeness sake. I'd be happy to write
   > a dedicated section of these docs, although I think this page seems
   > destined to be split into many pages: one describing the approach for each
   > kind of extension.
   >
   > Hi @mitchlloyd <https://github.com/mitchlloyd>, I assume you are
   > interested in writing docs what @suneet-s <https://github.com/suneet-s>
   > mentioned based on your comment above. Do you want to add them in this PR?
   > I think that could be done in a follow-up PR if you want.
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/druid/pull/9319?email_source=notifications&email_token=AAADWQPAJMXRT47DZ4NL4XLRCHJUZA5CNFSM4KQXQN52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCU6PYFQ#discussion_r377360313>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAADWQIRNDWSRSEOEWZEB7TRCHJUZANCNFSM4KQXQN5Q>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org