You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2026/04/02 02:16:03 UTC
Re: [PR] Split the `collect_http_params` as per plugins for better performance [skywalking]
codecov[bot] commented on PR #4170:
URL: https://github.com/apache/skywalking/pull/4170#issuecomment-4174167089
## [Codecov](https://app.codecov.io/gh/apache/skywalking/pull/4170?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 26.83%. Comparing base ([`0f6b5c8`](https://app.codecov.io/gh/apache/skywalking/commit/0f6b5c8def0f462c584b2eb336166028c09d459d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bc3d60d`](https://app.codecov.io/gh/apache/skywalking/commit/bc3d60d5448e7fb44a3d0aa40f7a37088251a7d3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3076 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/skywalking/pull/4170?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&filepath=apm-sniffer%2Fapm-agent-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fskywalking%2Fapm%2Fagent%2Fcore%2Fconf%2FConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...commons/interceptor/AbstractMethodInterceptor.java](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&filepath=apm-sniffer%2Fapm-sdk-plugin%2Fspring-plugins%2Fmvc-annotation-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fskywalking%2Fapm%2Fplugin%2Fspring%2Fmvc%2Fcommons%2Finterceptor%2FAbstractMethodInterceptor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&filepath=apm-sniffer%2Fapm-sdk-plugin%2Ftomcat-7.x-8.x-plugin%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fskywalking%2Fapm%2Fplugin%2Ftomcat78x%2FTomcatInvokeInterceptor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking/pull/4170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4170 +/- ##
==========================================
- Coverage 26.83% 26.83% -0.01%
==========================================
Files 1161 1161
Lines 25409 25410 +1
Branches 3689 3689
==========================================
Hits 6819 6819
- Misses 17981 17982 +1
Partials 609 609
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking/pull/4170?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org