You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/19 13:08:57 UTC

[GitHub] [skywalking] kezhenxu94 commented on pull request #7470: Add all agent config to `agent.conf` file for convenient containerization use cases

kezhenxu94 commented on pull request #7470:
URL: https://github.com/apache/skywalking/pull/7470#issuecomment-922471256


   > I find some configurations are in configurations.md , but not in the agent.config , such as ```agent.trace_segment_ref_limit_per_span``` 、```agent.instance_properties[key]=value``` . Otherwise , the configuration ```plugin.dubbo.consumer_provider_length_threshold ``` in the agent.config is not the same as ```plugin.dubbo.provider_arguments_length_threshold``` in the configurations.md.  
   
   @dashanji can you open a pull request to fix this? For `agent.instance_properties[xxx]`, I think we also need to migrate to the format of `agent.instance_properties_json`.  `plugin.dubbo.consumer_provider_length_threshold` should be typo of `plugin.dubbo.consumer_length_threshold`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org