You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/08 08:42:50 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11196: fix: skip unit test that is failing in master for test-postgres-hive

dpgaspar commented on a change in pull request #11196:
URL: https://github.com/apache/incubator-superset/pull/11196#discussion_r501547666



##########
File path: tests/datasets/api_tests.py
##########
@@ -870,6 +870,9 @@ def test_export_dataset(self):
             if export_table["table_name"] == "birth_names":
                 expected_response = export_table
                 break
+        else:

Review comment:
       On other places we are using `if backend() == "hive":` then skip test for example




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org