[GitHub] [ozone] elek commented on pull request #2053: HDDS-4988. Cancel duplicate PR workflows

[GitBox <gi...@apache.org>]

elek commented on pull request #2053:
URL: https://github.com/apache/ozone/pull/2053#issuecomment-811906009


   Yes, something like this. 
   
   Still I am not sure the benefit of using git submodules here (even if airflow uses this pattern).
   
   When I clone the repository. I don't need the source code of this optional tool. It is not required when Intellij indexes all the files, it's not required when I do a grep, it's not required when I execute any tool (like counting lines,...) and so on...
   
   The linked repository is not governed by Ozone PMC and not an Apache project, even if can be included in the same local source tree (if git submodules are updated)  
   
   My -- very subjective, I admit  -- feeling is using a normal checkout instead of submodule has a stronger separation:
   
   ```
   jobs:
     cancel-duplicate-ci-runs:
       name: "Cancel duplicate CI runs"
       runs-on: ubuntu-18.04
       steps:
         - name: Checkout project
           uses: actions/checkout@v2
           with:
             repository: https://github.com/potiuk/cancel-workflow-runs.git
             ref:  a81b3c4d59c61e27484cfacdc13897dd908419c9
             persist-credentials: false
   ```          
   
   But I should admit that this is more like a personal preference, or feeling. While I think there is no doubt that checkout provides better separation, I have no **strong technical** arguments against using submodules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org