You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2017/03/30 14:29:14 UTC
[GitHub] couchdb-fauxton pull request #893: consistent error message for views and do...
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/893
consistent error message for views and doc
This fixes #890
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton warning-messages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/893.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #893
----
commit fd1fe4dd260e8ccc06d244dfce4b03fb2e9dc400
Author: Garren Smith <ga...@gmail.com>
Date: 2017-03-30T14:27:24Z
consistent error message for views and doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #893: consistent error message for views and doc
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/893
+1 pending travis and addressing my comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #893: consistent error message for views and do...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #893: consistent error message for views and do...
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/893#discussion_r108957741
--- Diff: app/addons/documents/index-results/actions.js ---
@@ -63,8 +63,9 @@ export default {
if (responseText.reason) {
errorMsg = responseText.reason;
}
- if (responseText.error && responseText.error === 'not_found') {
- return;
+
+ if (responseText.reason && responseText.reason === 'missing_named_view') {
+ errorMsg = 'The <index_name> <index_type> does not exist.';
--- End diff --
I'd suggest coming up with a more readable error message for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---