You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/05/01 18:53:24 UTC
Review Request 20954: Patch for KAFKA-1412
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20954/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1412
https://issues.apache.org/jira/browse/KAFKA-1412
Repository: kafka
Description
-------
1. Move createNewProducer() to TestUtils. 2. Add retries in the testcase that auto-creates the topic.
Diffs
-----
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 839fd27ba8c1c8c55c0f9d89b11ea43718662df4
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 223033399a4448ea33e1434ca2742062f9fc0599
core/src/test/scala/unit/kafka/utils/TestUtils.scala 49c7790c995bb2e79322eb148ab80d0dcccefed4
Diff: https://reviews.apache.org/r/20954/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20954: Patch for KAFKA-1412
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20954/#review41924
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On May 1, 2014, 4:53 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20954/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 4:53 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1412
> https://issues.apache.org/jira/browse/KAFKA-1412
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Move createNewProducer() to TestUtils. 2. Add retries in the testcase that auto-creates the topic.
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 839fd27ba8c1c8c55c0f9d89b11ea43718662df4
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 223033399a4448ea33e1434ca2742062f9fc0599
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 49c7790c995bb2e79322eb148ab80d0dcccefed4
>
> Diff: https://reviews.apache.org/r/20954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20954: Patch for KAFKA-1412
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20954/#review41955
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On May 1, 2014, 4:53 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20954/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 4:53 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1412
> https://issues.apache.org/jira/browse/KAFKA-1412
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Move createNewProducer() to TestUtils. 2. Add retries in the testcase that auto-creates the topic.
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 839fd27ba8c1c8c55c0f9d89b11ea43718662df4
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 223033399a4448ea33e1434ca2742062f9fc0599
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 49c7790c995bb2e79322eb148ab80d0dcccefed4
>
> Diff: https://reviews.apache.org/r/20954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>