[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

["Benjamin Reed (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460874#comment-13460874 ] 

Benjamin Reed commented on ZOOKEEPER-107:
-----------------------------------------

looks good. a couple of small comments:

1) you need a testcase for async reconfig. it appears that ReconfigCallback is not used.
2) need to comment backward compatibility processing in FastLeaderElection.
3) the check for short packet in the run() of FastLeaderElection needs to be moved up before any packet processing takes place.
4) in LearnerHandler some of the info messages should be debug
5) in LearnerHandler, newLeaderData was changed to be 12 bytes, but only first 4 are used like before. why?
6) in Leader, it doesn't look like SHUTDOWN is fully there, we should remove it
7) there are warns and errors in Leader and QuorumPeer that looks like it needs to be a debug
8) add comment in processAck to explain why multiple outstanding proposals may be ready to commit after reconfig
9) In QuorumUtil, please put a comment with the jira number which relates to the JMX broken code

great set of tests! i think we have excellent coverage of scenarios. we just need to do a simple test for 1) to make sure it works.
                
> Allow dynamic changes to server cluster membership
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-107
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members
>
>
> Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira