You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/29 10:43:13 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
morningman opened a new pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342
## Proposed changes
Use `commitAsync` to commit offset to kafka, instread of using `commitSync`, which may block for a long time.
Also assign a group.id to routine load if user not specified "property.group.id" property, so that all consumer of
this job will use same group.id instead of a random id for each consume task.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#issuecomment-889603404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman removed a comment on pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
morningman removed a comment on pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#issuecomment-889017926
#6306 will cause BE crash in DEBUG mode, remove this service will fix that bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#issuecomment-889038168
Please add a issue link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#discussion_r679116059
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -344,30 +345,54 @@ public long getMinTaskBeId(String clusterName) throws LoadException {
// check if the specified BE is available for running task
// return true if it is available. return false if otherwise.
// throw exception if unrecoverable errors happen.
- public boolean checkBeToTask(long beId, String clusterName) throws LoadException {
+ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws LoadException {
List<Long> beIdsInCluster = Catalog.getCurrentSystemInfo().getClusterBackendIds(clusterName, true);
if (beIdsInCluster == null) {
throw new LoadException("The " + clusterName + " has been deleted");
}
- if (!beIdsInCluster.contains(beId)) {
- return false;
+ if (previoudBeId != -1L && !beIdsInCluster.contains(previoudBeId)) {
+ return -1L;
}
// check if be has idle slot
readLock();
try {
- int idleTaskNum = 0;
Map<Long, Integer> beIdToConcurrentTasks = getBeCurrentTasksNumMap();
- if (beIdToConcurrentTasks.containsKey(beId)) {
- idleTaskNum = beIdToMaxConcurrentTasks.get(beId) - beIdToConcurrentTasks.get(beId);
- } else {
- idleTaskNum = Config.max_routine_load_task_num_per_be;
+ // 1. Find if the given BE id has available slots
+ if (previoudBeId != -1L) {
+ int idleTaskNum = 0;
+ if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = beIdToMaxConcurrentTasks.get(previoudBeId) - beIdToConcurrentTasks.get(previoudBeId);
+ } else {
+ idleTaskNum = Config.max_routine_load_task_num_per_be;
+ }
+ if (idleTaskNum > 0) {
+ return previoudBeId;
+ }
}
- if (idleTaskNum > 0) {
- return true;
+
+ // 2. The given BE id does not have available slots, find a BE with min tasks
+ updateBeIdToMaxConcurrentTasks();
+ int idleTaskNum = 0;
+ long resultBeId = -1L;
+ int maxIdleSlotNum = 0;
+ for (Long beId : beIdsInCluster) {
Review comment:
i merged the 2 methods to avoid call getBeCurrentTasksNumMap twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#discussion_r679074901
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -344,30 +345,54 @@ public long getMinTaskBeId(String clusterName) throws LoadException {
// check if the specified BE is available for running task
// return true if it is available. return false if otherwise.
// throw exception if unrecoverable errors happen.
- public boolean checkBeToTask(long beId, String clusterName) throws LoadException {
+ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws LoadException {
List<Long> beIdsInCluster = Catalog.getCurrentSystemInfo().getClusterBackendIds(clusterName, true);
if (beIdsInCluster == null) {
throw new LoadException("The " + clusterName + " has been deleted");
}
- if (!beIdsInCluster.contains(beId)) {
- return false;
+ if (previoudBeId != -1L && !beIdsInCluster.contains(previoudBeId)) {
+ return -1L;
}
// check if be has idle slot
readLock();
try {
- int idleTaskNum = 0;
Map<Long, Integer> beIdToConcurrentTasks = getBeCurrentTasksNumMap();
- if (beIdToConcurrentTasks.containsKey(beId)) {
- idleTaskNum = beIdToMaxConcurrentTasks.get(beId) - beIdToConcurrentTasks.get(beId);
- } else {
- idleTaskNum = Config.max_routine_load_task_num_per_be;
+ // 1. Find if the given BE id has available slots
+ if (previoudBeId != -1L) {
+ int idleTaskNum = 0;
+ if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = beIdToMaxConcurrentTasks.get(previoudBeId) - beIdToConcurrentTasks.get(previoudBeId);
+ } else {
+ idleTaskNum = Config.max_routine_load_task_num_per_be;
+ }
+ if (idleTaskNum > 0) {
+ return previoudBeId;
+ }
}
- if (idleTaskNum > 0) {
- return true;
+
+ // 2. The given BE id does not have available slots, find a BE with min tasks
+ updateBeIdToMaxConcurrentTasks();
+ int idleTaskNum = 0;
+ long resultBeId = -1L;
+ int maxIdleSlotNum = 0;
+ for (Long beId : beIdsInCluster) {
Review comment:
This logic is consistent with manager's getMinTaskBeId function logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6342: [Bug][RoutineLoad] Avoid TOO_MANY_TASKS error
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6342:
URL: https://github.com/apache/incubator-doris/pull/6342#issuecomment-889017926
#6306 will cause BE crash in DEBUG mode, remove this service will fix that bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org