You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/04/18 10:59:23 UTC
Re: Review Request 57443: Useless configuration in unixauthservice
pom.xml lead to project compiler error in eclipse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57443/#review172183
-----------------------------------------------------------
Shouldn't we include log4j.properties in src/main/resources as well? Then we can just delete the build section from the pom, as the log4j.properties get automatically copied to classes.
- Colm O hEigeartaigh
On March 9, 2017, 3:13 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57443/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 3:13 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1438
> https://issues.apache.org/jira/browse/RANGER-1438
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Useless configuration in unixauthservice pom.xml lead to project compiler error in eclipse
>
> Steps
> In windows environment, enter into ranger project root directory
> 1.Execute : mvn clean compile package install assembly:assembly -DskipTests -X
> 2.Execute :mvn eclipse:eclipse -X
> When the maven project convert into eclipse project occurred error:
> [[ERROR] Failed to execute goal org.apache.maven.plugins:maven-eclipse-plugin:2.10:eclipse (default-cli) on project unixauthservice: Cant canonicalize system path:
> {0}:???????????????? -> [Help 1]
> Caused by: org.apache.maven.plugin.MojoExecutionException: Cant canonicalize system path: {0}
> ]
> 3.Remove unless code in unixauthservice pom.xml
> <build>
> <resources>
> <resource>
> <targetPath>$
> {project.build.outputDirectory}
> </targetPath>
> <directory>conf.dist</directory>
> <includes>
> <include>log4j.properties</include>
> </includes>
> </resource>
> </resources>
> </build>
> 4.Rerun : mvn clean compile package install assembly:assembly -DskipTests -X
> 5.Rerun :mvn eclipse:eclipse -X (result:sucessed)
> 6.Check whether affect the Usersync Components work
> 1).Install the ranger-1.0.0-SNAPSHOT-usersync module in a new machine
> 2).and Reinstall the ranger-1.0.0-SNAPSHOT-usersync module in original machine
> 3)result:both work well ( Log upload in the attachment)
>
>
> Diffs
> -----
>
> unixauthservice/pom.xml cc8fb1c
>
>
> Diff: https://reviews.apache.org/r/57443/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57443: Useless configuration in unixauthservice
pom.xml lead to project compiler error in eclipse
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On April 18, 2017, 10:59 a.m., Colm O hEigeartaigh wrote:
> > Shouldn't we include log4j.properties in src/main/resources as well? Then we can just delete the build section from the pom, as the log4j.properties get automatically copied to classes.
*bump*
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57443/#review172183
-----------------------------------------------------------
On March 9, 2017, 3:13 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57443/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 3:13 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1438
> https://issues.apache.org/jira/browse/RANGER-1438
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Useless configuration in unixauthservice pom.xml lead to project compiler error in eclipse
>
> Steps
> In windows environment, enter into ranger project root directory
> 1.Execute : mvn clean compile package install assembly:assembly -DskipTests -X
> 2.Execute :mvn eclipse:eclipse -X
> When the maven project convert into eclipse project occurred error:
> [[ERROR] Failed to execute goal org.apache.maven.plugins:maven-eclipse-plugin:2.10:eclipse (default-cli) on project unixauthservice: Cant canonicalize system path:
> {0}:???????????????? -> [Help 1]
> Caused by: org.apache.maven.plugin.MojoExecutionException: Cant canonicalize system path: {0}
> ]
> 3.Remove unless code in unixauthservice pom.xml
> <build>
> <resources>
> <resource>
> <targetPath>$
> {project.build.outputDirectory}
> </targetPath>
> <directory>conf.dist</directory>
> <includes>
> <include>log4j.properties</include>
> </includes>
> </resource>
> </resources>
> </build>
> 4.Rerun : mvn clean compile package install assembly:assembly -DskipTests -X
> 5.Rerun :mvn eclipse:eclipse -X (result:sucessed)
> 6.Check whether affect the Usersync Components work
> 1).Install the ranger-1.0.0-SNAPSHOT-usersync module in a new machine
> 2).and Reinstall the ranger-1.0.0-SNAPSHOT-usersync module in original machine
> 3)result:both work well ( Log upload in the attachment)
>
>
> Diffs
> -----
>
> unixauthservice/pom.xml cc8fb1c
>
>
> Diff: https://reviews.apache.org/r/57443/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57443: Useless configuration in unixauthservice
pom.xml lead to project compiler error in eclipse
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 四月 18, 2017, 10:59 a.m., Colm O hEigeartaigh wrote:
> > Shouldn't we include log4j.properties in src/main/resources as well? Then we can just delete the build section from the pom, as the log4j.properties get automatically copied to classes.
>
> Colm O hEigeartaigh wrote:
> *bump*
Yes, this is a good idear to solution this problem, I had update the patch if you have time please review again.Thanks
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57443/#review172183
-----------------------------------------------------------
On 七月 5, 2017, 3:37 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57443/
> -----------------------------------------------------------
>
> (Updated 七月 5, 2017, 3:37 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1438
> https://issues.apache.org/jira/browse/RANGER-1438
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Useless configuration in unixauthservice pom.xml lead to project compiler error in eclipse
>
> Steps
> In windows environment, enter into ranger project root directory
> 1.Execute : mvn clean compile package install assembly:assembly -DskipTests -X
> 2.Execute :mvn eclipse:eclipse -X
> When the maven project convert into eclipse project occurred error:
> [[ERROR] Failed to execute goal org.apache.maven.plugins:maven-eclipse-plugin:2.10:eclipse (default-cli) on project unixauthservice: Cant canonicalize system path:
> {0}:???????????????? -> [Help 1]
> Caused by: org.apache.maven.plugin.MojoExecutionException: Cant canonicalize system path: {0}
> ]
> 3.Remove unless code in unixauthservice pom.xml
> <build>
> <resources>
> <resource>
> <targetPath>$
> {project.build.outputDirectory}
> </targetPath>
> <directory>conf.dist</directory>
> <includes>
> <include>log4j.properties</include>
> </includes>
> </resource>
> </resources>
> </build>
> 4.Rerun : mvn clean compile package install assembly:assembly -DskipTests -X
> 5.Rerun :mvn eclipse:eclipse -X (result:sucessed)
> 6.Check whether affect the Usersync Components work
> 1).Install the ranger-1.0.0-SNAPSHOT-usersync module in a new machine
> 2).and Reinstall the ranger-1.0.0-SNAPSHOT-usersync module in original machine
> 3)result:both work well ( Log upload in the attachment)
>
>
> Diffs
> -----
>
> unixauthservice/pom.xml cc8fb1c
> unixauthservice/src/main/resources/log4j.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57443/diff/3/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>