[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18679: [fix][load] add thread pool for sinker

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18679:
URL: https://github.com/apache/doris/pull/18679#discussion_r1166617156


##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
         _env->_master_info = new TMasterInfo();
         _env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();

Review Comment:
   warning: '_internal_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
   ```cpp
           _env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
                 ^
   ```
   **be/src/runtime/exec_env.h:248:** declared private here
   ```cpp
       BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
                                              ^
   ```
   



##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@ class VOlapTableSinkTest : public testing::Test {
         _env->_master_info = new TMasterInfo();

Review Comment:
   warning: '_master_info' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
   ```cpp
           _env->_master_info = new TMasterInfo();
                 ^
   ```
   **be/src/runtime/exec_env.h:241:** declared private here
   ```cpp
       TMasterInfo* _master_info = nullptr;
                    ^
   ```
   



##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
         _env->_master_info = new TMasterInfo();
         _env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
         _env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
+        ThreadPoolBuilder("SinkerThreadPool")
+                .set_min_threads(1)
+                .set_max_threads(5)
+                .set_max_queue_size(100)
+                .build(&_env->_sinker_thread_pool);

Review Comment:
   warning: '_sinker_thread_pool' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
   ```cpp
                   .build(&_env->_sinker_thread_pool);
                                 ^
   ```
   **be/src/runtime/exec_env.h:221:** declared private here
   ```cpp
       std::unique_ptr<ThreadPool> _sinker_thread_pool;
                                   ^
   ```
   



##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
         _env->_master_info = new TMasterInfo();
         _env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
         _env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();

Review Comment:
   warning: '_function_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
   ```cpp
           _env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
                 ^
   ```
   **be/src/runtime/exec_env.h:249:** declared private here
   ```cpp
       BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
                                               ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org