[GitHub] kishoreg commented on a change in pull request #3568: Add guava cache to cache table schema in pinot broker

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #3568: Add guava cache to cache table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r238048599
 
 

 ##########
 File path: pinot-common/src/main/java/com/linkedin/pinot/common/utils/CommonConstants.java
 ##########
 @@ -118,10 +118,15 @@ public ServerType getServerType() {
     public static final String CONFIG_OF_BROKER_REFRESH_TIMEBOUNDARY_INFO_SLEEP_INTERVAL =
             "pinot.broker.refresh.timeBoundaryInfo.sleepInterval";
     public static final long DEFAULT_BROKER_REFRESH_TIMEBOUNDARY_INFO_SLEEP_INTERVAL_MS = 10000L;
+    public static final String CONFIG_OF_TABLE_SCHEMA_MAXIMUM_CACHE_SIZE = "pinot.broker.table.schema.cache.size";
 
 Review comment:
   Why are we setting this?  If we have more than 2k tables, we will bombard ZK right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org