[GitHub] [logging-log4j2] qxo commented on issue #300: call #StatusLogger.getLogger() only when it's needed.

[GitBox <gi...@apache.org>]

qxo commented on issue #300: call #StatusLogger.getLogger() only when it's needed.
URL: https://github.com/apache/logging-log4j2/pull/300#issuecomment-528440458
 
 
   > This change looks fine to me. Are there any specific startup scenarios you came across that warrants this?
   > 
   > Edit: I see what you mean. Can you also file a Jira ticket for this? https://issues.apache.org/jira/projects/LOG4J2/issues
   > 
   > Also, if you rebase from master, you should get a working Travis config.
   
   1. rebase from master was done:)
   2. the startup scenarios was :
      we use custom ServletContextListener for init the app, include the logging system
      so we need ` Log4jWebSupport.IS_LOG4J_AUTO_INITIALIZATION_DISABLED=true `
     but the `static final LOGGER=StatusLogger.getLogger() ` on Log4jServletContainerInitializer will break custom init for log4j2
   
   3. the apache Jira is so slow from China... sorry for this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services