You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/06/21 22:17:52 UTC
Review Request 60346: Improved the documentation of 'TASK_LOST'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60346/
-----------------------------------------------------------
Review request for mesos and Neil Conway.
Bugs: MESOS-7662
https://issues.apache.org/jira/browse/MESOS-7662
Repository: mesos
Description
-------
Updated the protobuf comments to clarify that 'TASK_LOST' is not
always a terminal state.
Diffs
-----
include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2
include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2
Diff: https://reviews.apache.org/r/60346/diff/1/
Testing
-------
None, this is not functional change.
Thanks,
Gastón Kleiman
Re: Review Request 60346: Improved the documentation of 'TASK_LOST'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60346/#review178588
-----------------------------------------------------------
Bad patch!
Reviews applied: [60346]
Failed command: python support/apply-reviews.py -n -r 60346
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 381, in <module>
reviewboard()
File "support/apply-reviews.py", line 360, in reviewboard
apply_review()
File "support/apply-reviews.py", line 126, in apply_review
commit_patch()
File "support/apply-reviews.py", line 225, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 111, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/105/console
- Mesos Reviewbot Windows
On June 21, 2017, 3:17 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60346/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3:17 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7662
> https://issues.apache.org/jira/browse/MESOS-7662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the protobuf comments to clarify that 'TASK_LOST' is not
> always a terminal state.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2
> include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2
>
>
> Diff: https://reviews.apache.org/r/60346/diff/1/
>
>
> Testing
> -------
>
> None, this is not functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 60346: Improved the documentation of 'TASK_LOST'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60346/#review178689
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60346]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 21, 2017, 10:17 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60346/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 10:17 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7662
> https://issues.apache.org/jira/browse/MESOS-7662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the protobuf comments to clarify that 'TASK_LOST' is not
> always a terminal state.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2
> include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2
>
>
> Diff: https://reviews.apache.org/r/60346/diff/1/
>
>
> Testing
> -------
>
> None, this is not functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 60346: Improved the documentation of 'TASK_LOST'.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60346/#review179725
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto
Lines 1940 (patched)
<https://reviews.apache.org/r/60346/#comment254563>
We don't support the "strict-registry" flag anymore, so I removed the reference to this before committing.
- Neil Conway
On June 21, 2017, 10:17 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60346/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 10:17 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7662
> https://issues.apache.org/jira/browse/MESOS-7662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the protobuf comments to clarify that 'TASK_LOST' is not
> always a terminal state.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2
> include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2
>
>
> Diff: https://reviews.apache.org/r/60346/diff/1/
>
>
> Testing
> -------
>
> None, this is not functional change.
>
>
> Thanks,
>
> Gastón Kleiman
>
>