You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 18:15:18 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2203: Remove tokio::spawn from WindowAggExec (#2201)

alamb commented on code in PR #2203:
URL: https://github.com/apache/arrow-datafusion/pull/2203#discussion_r849766944


##########
datafusion/core/src/physical_plan/windows/window_agg_exec.rs:
##########
@@ -232,16 +230,14 @@ fn compute_window_aggregates(
         .collect()
 }
 
-pin_project! {

Review Comment:
   Turns out cargo culting was copying bad habits around. 👍  for cleaning this up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org