You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/04 00:34:36 UTC

[jira] [Commented] (HBASE-4070) [Coprocessors] Improve region server metrics to report loaded coprocessors to master

    [ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119698#comment-13119698 ] 

jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------

(Updated 2011-10-03 22:32:46.964479)


Review request for hbase and Mingjie Lai.


Changes
-------

use String[] as the return type to report loaded coprocessors.


Summary
-------

Proposed fix for HBASE-4070. 


This addresses bug HBASE-4070.
    https://issues.apache.org/jira/browse/HBASE-4070


Diffs (updated)
-----

  src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850 
  src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb 
  src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd 
  src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4 
  src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1 
  src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2029/diff


Testing
-------

Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported() included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.


Thanks,

Eugene


                
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-4070
>                 URL: https://issues.apache.org/jira/browse/HBASE-4070
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.3
>            Reporter: Mingjie Lai
>            Assignee: Eugene Koontz
>         Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need a way to report this piece of information from region to master (or just at region server level). So later on, we can display the loaded class names at shell as well as web console. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira