You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jclalala <gi...@git.apache.org> on 2016/01/29 14:16:38 UTC
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
GitHub user jclalala opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/78
CB-10476 - fix problem where callbacks were not invoked on android du…
seems like the faulty code was added back in this commit:
https://github.com/apache/cordova-plugin-media/commit/c4547c94c5850c619b0936551ec1180f4465a95b#diff-ea1d1dcd03fa62ee9f2774edbf524977
line 121.
problem happens when messageChannel is reset with callbackContext every call... removing this will fix the problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jclalala/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 8801f3943c557a82747781696f1e20978b8184e0
Author: Jeffrey Chang <je...@stiteq.com>
Date: 2016-01-29T13:13:59Z
CB-10476 - fix problem where callbacks were not invoked on android due to messageChannel being overridden by callbackContext in every execut() call
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-181495681
@vladimir-kotikov sure thing. @jclalala has the ICLA been processed? Does your name appear [here](https://people.apache.org/committer-index.html#unlistedclas) yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by drbeermann <gi...@git.apache.org>.
Github user drbeermann commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180462324
+1 Fixes a few issues for me as well. Still having problems with multiple audio files playing on marshmallow however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-181298201
@riknoll, I was going to start plugins release on Tue. Would you be able to merge this before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by hdsnet <gi...@git.apache.org>.
Github user hdsnet commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-179223182
Works like charm. Please merge asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by hdsnet <gi...@git.apache.org>.
Github user hdsnet commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-179215307
Hi,
It still doesn't seem to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by jclalala <gi...@git.apache.org>.
Github user jclalala commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180790055
Submitted ICLA.
On Sat, Feb 6, 2016 at 11:01 PM, Laurent Deketelaere <
notifications@github.com> wrote:
> +1
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180782691>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180486950
This LGTM. Seems like our tests have been failing for a while with cordova-plugin-media, and this was the cause
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by aliokan <gi...@git.apache.org>.
Github user aliokan commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180782691
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658516
Actually it might have to wait until Monday before I can get to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658674
In the meantime, @jclalala can you [submit an ICLA](http://www.apache.org/licenses/#clas)? It's better for us to have one on file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by jclalala <gi...@git.apache.org>.
Github user jclalala commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-181687605
My name doesn't show up yet but I did get a mail from clr@apache.org
stating the ICLA has been filed:
[image: Inline image 1]
On Tue, Feb 9, 2016 at 3:52 AM, Richard Knoll <no...@github.com>
wrote:
> @vladimir-kotikov <https://github.com/vladimir-kotikov> sure thing.
> @jclalala <https://github.com/jclalala> has the ICLA been processed? Does
> your name appear here
> <https://people.apache.org/committer-index.html#unlistedclas> yet?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-181495681>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by pavei <gi...@git.apache.org>.
Github user pavei commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180847087
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180492977
I have tested this by running cordova-mobile-spec on a 6.0.1 device, 5.1.1 emulator, and 4.44 emulator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180528497
@infil00p to review. I think this should fix most of the errors we are seeing in [the CI](https://ci.apache.org/builders/cordova-android-win/builds/1523/steps/getting-test-results/logs/stdio). Was there a reason for the original change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180656412
Alright, I'm going to merge this in. It's small enough to not require an ICLA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...
Posted by tony-- <gi...@git.apache.org>.
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180593938
+1 this fixed the tests for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org