[GitHub] [pulsar] eolivelli commented on a change in pull request #9226: [flaky test] Fix unit tests that occasionally fail

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9226:
URL: https://github.com/apache/pulsar/pull/9226#discussion_r559205671



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorRateLimiterTest.java
##########
@@ -145,6 +145,11 @@ public void testReplicatorRatePriority() throws Exception {
                 assertEquals(topic.getReplicators().values().get(0).getRateLimiter().get().getDispatchRateOnMsg(), 100));
         assertEquals(topic.getReplicators().values().get(0).getRateLimiter().get().getDispatchRateOnByte(),
                 200L);
+        //restore config
+        config1.setSystemTopicEnabled(false);

Review comment:
       We should not do this way.
   In case we change the default value here we are going to set arbitrary values.
   Can you find a way to reset those values to the values that were set at the beginning of the test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org