You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/06/19 08:22:55 UTC
[GitHub] [servicecomb-java-chassis] Matrix0xCC opened a new pull request, #3096: [SCB-2582]bump apache version from 21 to 25
Matrix0xCC opened a new pull request, #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096
1. bump `apache` version from `21` to `25`
3. fix broken test cases caused by duplicate class `TestNullFieldAndDefaultValueParam`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#issuecomment-1159658220
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3096](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea93428) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/5728e1821d70eff4d1e44f2d093f76220d3d2fb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5728e18) will **increase** coverage by `0.02%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #3096 +/- ##
============================================
+ Coverage 77.48% 77.50% +0.02%
- Complexity 1414 1431 +17
============================================
Files 1611 1612 +1
Lines 43214 43257 +43
Branches 3640 3646 +6
============================================
+ Hits 33486 33528 +42
+ Misses 8230 8224 -6
- Partials 1498 1505 +7
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bjectparams/TestNullFieldAndDefaultValueParam.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdHMvaXQtY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2l0L3NjaGVtYS9vYmplY3RwYXJhbXMvVGVzdE51bGxGaWVsZEFuZERlZmF1bHRWYWx1ZVBhcmFtLmphdmE=) | `74.41% <0.00%> (ø)` | |
| [...ache/servicecomb/it/deploy/MicroserviceDeploy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdHMvaXQtY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2l0L2RlcGxveS9NaWNyb3NlcnZpY2VEZXBsb3kuamF2YQ==) | `82.75% <100.00%> (ø)` | |
| [...ecomb/provider/pojo/PojoConsumerMetaRefresher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vUG9qb0NvbnN1bWVyTWV0YVJlZnJlc2hlci5qYXZh) | `75.60% <0.00%> (-2.44%)` | :arrow_down: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.86% <0.00%> (+1.08%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.04% <0.00%> (+1.14%)` | :arrow_up: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `66.40% <0.00%> (+1.60%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `80.37% <0.00%> (+1.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5728e18...ea93428](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3096?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj merged pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Matrix0xCC commented on a diff in pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Matrix0xCC commented on code in PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#discussion_r901081036
##########
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/MicroserviceDeploy.java:
##########
@@ -43,7 +43,12 @@ public MicroserviceDeployDefinition getMicroserviceDeployDefinition() {
@Override
protected String[] createCmds() {
// must set jar at the end of the cmds
- return new String[] {"java", "-jar"};
+ return new String[] {"java", "-jar",
+ //add a property definition to enable quick search in taskmgr
+ "-DCombDeploy=true",
+ //remote debug, default disabled
+ //"-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=0.0.0.0:" + RandomUtils.nextInt(60000, 61000)
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#discussion_r901075857
##########
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/MicroserviceDeploy.java:
##########
@@ -43,7 +43,12 @@ public MicroserviceDeployDefinition getMicroserviceDeployDefinition() {
@Override
protected String[] createCmds() {
// must set jar at the end of the cmds
- return new String[] {"java", "-jar"};
+ return new String[] {"java", "-jar",
+ //add a property definition to enable quick search in taskmgr
+ "-DCombDeploy=true",
+ //remote debug, default disabled
+ //"-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=0.0.0.0:" + RandomUtils.nextInt(60000, 61000)
Review Comment:
commented out code. we can make it a config in Deploy like heap memory config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#discussion_r901075240
##########
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/MicroserviceDeploy.java:
##########
@@ -43,7 +43,12 @@ public MicroserviceDeployDefinition getMicroserviceDeployDefinition() {
@Override
protected String[] createCmds() {
// must set jar at the end of the cmds
- return new String[] {"java", "-jar"};
+ return new String[] {"java", "-jar",
Review Comment:
I suggest don't commit this change if not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#discussion_r901075662
##########
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/MicroserviceDeploy.java:
##########
@@ -43,7 +43,12 @@ public MicroserviceDeployDefinition getMicroserviceDeployDefinition() {
@Override
protected String[] createCmds() {
// must set jar at the end of the cmds
- return new String[] {"java", "-jar"};
+ return new String[] {"java", "-jar",
+ //add a property definition to enable quick search in taskmgr
+ "-DCombDeploy=true",
Review Comment:
can we use jps to find the process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Matrix0xCC commented on a diff in pull request #3096: [SCB-2582]bump apache version from 21 to 25
Posted by GitBox <gi...@apache.org>.
Matrix0xCC commented on code in PR #3096:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3096#discussion_r901080983
##########
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/MicroserviceDeploy.java:
##########
@@ -43,7 +43,12 @@ public MicroserviceDeployDefinition getMicroserviceDeployDefinition() {
@Override
protected String[] createCmds() {
// must set jar at the end of the cmds
- return new String[] {"java", "-jar"};
+ return new String[] {"java", "-jar",
+ //add a property definition to enable quick search in taskmgr
+ "-DCombDeploy=true",
Review Comment:
It's just a marker to search in windows task manager, I'll remove it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org