You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/02/18 16:23:22 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request #85: Image, Icon, Rfixes
Shanedell opened a new pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85
Multiple Updates:
- Update apache daffodil logo to be png not svg
- Fix icon issue by:
- Downloading apache daffodil logo locally to images folder
- Fix path to it in package.json "images/daffodil.png"
- Update binary name so that when yarn build run it creates "apache-daffodil-vscode-VERSION.vsix"
- change "name" attribute inside of package.json to "apache-daffodil-vscode"
Closes #81
Closes #82
Closes #83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810174809
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
So this icon will appear when you install extension here is a screenshot of mine with the current image
This is with the image you linked
Which do you prefer? I personally prefer the image you linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell merged pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810179341
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Yeah, I think the .ico looks better. I also found the [VS Code package.json documentation](https://code.visualstudio.com/api/references/extension-manifest) that says the icon property is:
> The path to the icon of at least 128x128 pixels (256x256 for Retina screens).
Doesn't say anything about the supported formats, but it looks like the .ico works for you. And I believe the .ico file has a bunch of built-in resolutions, ranging from 16x16 to 256x256, so should scale nicely if VS Code uses it anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810174809
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
So this icon will appear when you install extension.
Here is a screenshot of mine with the current image
This is with the image you linked
Which do you prefer? I personally prefer the image you linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810167515
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Should this be an actual icon file, or a standard square shape? Does this icon show up some where in VS Code?
We do have an actual .ico file used for the Windows MSI that we could reuse for this if an .ico file makes more sense than the log:
https://raw.githubusercontent.com/apache/daffodil/main/daffodil-cli/src/windows/apache-daffodil.ico
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810167515
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Should this be an actual icon file, or a standard square shape? Does this icon show up some where in VS Code?
We do have an actual .ico file used for the Windows MSI that we could reuse for this if an .ico file makes more sense than the logo:
https://raw.githubusercontent.com/apache/daffodil/main/daffodil-cli/src/windows/apache-daffodil.ico
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810180463
##########
File path: package.json
##########
@@ -1,5 +1,5 @@
{
- "name": "daffodil-debugger",
+ "name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil Schema Debugger",
Review comment:
Yeah, seems commit b5185aa26fefd0c39b47957e84467959875dc348 updated most places to use the "Apache Dafodil VS Code Extension" name. Probably just missed this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810187558
##########
File path: package.json
##########
@@ -1,5 +1,5 @@
{
- "name": "daffodil-debugger",
+ "name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil Schema Debugger",
Review comment:
updated `displayName` to `Apache Daffodil VS Code Extension`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810187199
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Updated extension to use the icon file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810168647
##########
File path: package.json
##########
@@ -1,5 +1,5 @@
{
- "name": "daffodil-debugger",
+ "name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil Schema Debugger",
Review comment:
Should this name be Apache Daffodil VS Code Extension? Or is this display name for something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810170048
##########
File path: package.json
##########
@@ -1,5 +1,5 @@
{
- "name": "daffodil-debugger",
+ "name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil Schema Debugger",
Review comment:
It could be if that would be more desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org