[GitHub] [iceberg] szehon-ho commented on a diff in pull request #7469: Core, Spark: Add configuration to control case sensitivity of CachingCatalog

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1181945744


##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -90,6 +90,8 @@
  *   <li><code>catalog-impl</code> - a custom {@link Catalog} implementation to use
  *   <li><code>default-namespace</code> - a namespace to use as the default
  *   <li><code>cache-enabled</code> - whether to enable catalog cache
+ *   <li><code>cache.case-sensitive</code> - whether the catalog cache should use case-sensitive

Review Comment:
   Key may be a bit abstract?
   
   "whether the catalog cache should compare table names in a case sensitive manner"?



##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -41,6 +41,11 @@ private CatalogProperties() {}
 
   public static final boolean CACHE_ENABLED_DEFAULT = true;
 
+  /** Controls whether the caching catalog will cache table entries using case-sensitive keys. */
+  public static final String CACHE_CASE_SENSITIVE = "cache.case-sensitive";
+
+  public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = false;

Review Comment:
   I see the current wrapCatalog two-arg call defaults to caseSensitive=true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org