You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 12:57:51 UTC

[GitHub] [airflow] turbaszek opened a new pull request #9819: Import Iterable from collections.abc in firestore operators

turbaszek opened a new pull request #9819:
URL: https://github.com/apache/airflow/pull/9819


   DeprecationWarning: Using or importing the ABCs from 'collections'
   instead of from 'collections.abc' is deprecated since Python 3.3,
   and in 3.9 it will stop working
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9819: Remove type hint causing DeprecationWarning in Firestore operators

Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9819:
URL: https://github.com/apache/airflow/pull/9819#discussion_r457504133



##########
File path: airflow/providers/google/firebase/operators/firestore.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from collections import Iterable
+from collections.abc import Iterable

Review comment:
       I removed it totally as there seems to be no value in this information. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #9819: Remove type hint causing DeprecationWarning in Firestore operators

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9819:
URL: https://github.com/apache/airflow/pull/9819


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] feluelle commented on a change in pull request #9819: Import Iterable from collections.abc in firestore operators

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9819:
URL: https://github.com/apache/airflow/pull/9819#discussion_r454367658



##########
File path: airflow/providers/google/firebase/operators/firestore.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from collections import Iterable
+from collections.abc import Iterable

Review comment:
       True.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9819: Import Iterable from collections.abc in firestore operators

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9819:
URL: https://github.com/apache/airflow/pull/9819#discussion_r454366178



##########
File path: airflow/providers/google/firebase/operators/firestore.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from collections import Iterable
+from collections.abc import Iterable

Review comment:
       It seems to me that here it will be better to use typing.Iterable. We only use it in types, not to create our own class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org