You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/01/22 08:09:29 UTC

[GitHub] rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group
URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162867659
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -951,16 +951,15 @@ def parse_network_rules(rules):
   if rules is None or len(rules) == 0:
     return ret
 
-  lines = rules.split(';')[:-1]
+  lines = rules.split('NEXT;')[:-1]
 
 Review comment:
   @wido what is the `NEXT` here? Can you give a sample of the rule/commands processed by this code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services