You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jdeppe-pivotal (GitHub)" <gi...@apache.org> on 2018/09/28 13:44:25 UTC

[GitHub] [geode] jdeppe-pivotal opened pull request #2536: GEODE-5212: Also use the host's canonical (fully qualified) name as a SAN in the certificate

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2536 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on issue #2536: GEODE-5212: Also use the host's canonical (fully qualified) name as a SAN in the certificate

Posted by "sboorlagadda (GitHub)" <gi...@apache.org>.
@jdeppe-pivotal There are couple more tests which may need a similar fix?
1. GfshHostNameVerificationDistributedTest
2. WANHostNameVerificationDistributedTest

[ Full content available at: https://github.com/apache/geode/pull/2536 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #2536: GEODE-5212: Also use the host's canonical (fully qualified) name as a SAN in the certificate

Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2536 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org