You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2020/10/28 01:02:27 UTC
[incubator-echarts-bot] 32/32: Merge pull request #7 from
plainheart/master
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-bot.git
commit 62958eb2ca7f2196ec62b99e3f9ef5647163f49c
Merge: 721cb2e 127e62e
Author: Zhongxiang.Wang <yh...@all-my-life.cn>
AuthorDate: Wed Oct 28 08:57:45 2020 +0800
Merge pull request #7 from plainheart/master
fix: use `isCoreCommitter` instead of `isCommitter` to be compatible with the committers who are hiding their membership in organization.
index.js | 7 +++----
src/text.js | 6 +++---
2 files changed, 6 insertions(+), 7 deletions(-)
diff --cc index.js
index 71e158e,6224d0c..4a05bbc
--- a/index.js
+++ b/index.js
@@@ -89,11 -89,10 +89,10 @@@ module.exports = app =>
});
app.on(['pull_request.opened'], async context => {
- // const auth = context.payload.pull_request.author_association;
const isCore = isCoreCommitter(context.payload.pull_request.user.login);
- const comment = context.github.issues.createComment(context.issue({
- body: isCore ? text.PR_OPENED_BY_COMMITTER : text.PR_OPENED
- }));
+ let commentText = isCore
+ ? text.PR_OPENED_BY_COMMITTER
+ : text.PR_OPENED;
const labelList = ['PR: awaiting review'];
if (isCore) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org