Re: better logging messages

[Hiram Chirino <hi...@hiramchirino.com>]

Hi Lionel,

Great suggestions.  I copied your email into
https://issues.apache.org/jira/browse/AMQ-3295 to track the change and
I've made the need updates.

Regards,
Hiram

FuseSource
Web: http://fusesource.com/

Connect at CamelOne May 24-26
The Open Source Integration Conference



On Thu, Apr 21, 2011 at 2:36 AM, Lionel Cons <li...@cern.ch> wrote:
> Hiram,
>
> I'm trying the latest Apollo snapshot and I see in the logs:
>
>  2011-04-21 08:16:12,536 connected: /127.0.0.1:53012
>
> Could you please add the local port number too?
>
> This is especially useful in case of failures. I got:
>
>  2011-04-21 08:14:16,970 authentication failed. address:/127.0.0.1:53008, reason:No associated certificates
>
> After investigation, it was the tcp port (and not the ssl port) so it
> was not at all related to certificates. A message such as "invalid
> user name or password" would be much better.
>
> Also, like for http://fusesource.com/issues/browse/DEV-3052, it would
> be useful to get the user name in case of authentication failures.
>
> Finally, to make the log parsers' life easier, it would be really nice
> to use a standard format for the messages. For instance something like:
>
>  connected: local:127.0.0.1:61613 remote:127.0.0.1:53012
>  authentication failed: local:127.0.0.1:61613 remote:127.0.0.1:53012 reason:"invalid user name or password" user:guesst
>
> FWIW, the "local" address could be useful in case of multihomed servers.
>
> If you don't want to bother about how to format key/value pairs, maybe
> you could use log4j's MDC?
>
> Cheers,
>
> Lionel
>