You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/24 12:01:37 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions
lordgamez opened a new pull request, #1459:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1459
Select processor metrics with regular expressions using `processorMetrics/` prefix.
Also fixes the issue that only processor metrics were allowed to be requested specifically in the DescribeMetrics operation. Now system metrics can also be specified in the `metricsClass` operation argument.
https://issues.apache.org/jira/browse/MINIFICPP-1987
---------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1459:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1459#discussion_r1031645830
##########
C2.md:
##########
@@ -117,6 +117,10 @@ a configuration of an agent
nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.name=ProcessorMetric
nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.classes=GetFileMetrics
+Processor metrics can also be configured using regular expressions with the `processorMetrics/` prefix, so the following definition is also valid:
Review Comment:
I would go for one of `processor/` or `processors/` prefixes instead, because it's obvious from the context it's used in that this is filtering metrics classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions
Posted by GitBox <gi...@apache.org>.
fgerlits closed pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions
URL: https://github.com/apache/nifi-minifi-cpp/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions
Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1459:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1459#discussion_r1031695415
##########
C2.md:
##########
@@ -117,6 +117,10 @@ a configuration of an agent
nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.name=ProcessorMetric
nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.classes=GetFileMetrics
+Processor metrics can also be configured using regular expressions with the `processorMetrics/` prefix, so the following definition is also valid:
Review Comment:
The reason I went with this instead is because we are filtering metrics not processors, so one would think that the `processors/` prefix means we have to specify `processors/TailFile` or `processors/GetFile` for example. In fact those would not match any processor metrics, because we use regex match instead of regex search in the implementation.
The other reason is that in this example it is obvious that we are referring to metrics, but in this context `nifi.c2.root.class.definitions.metrics` is an arbitrary user defined class, so the class may not contain the `metrics` in the class definition. In case the metrics are defined in an another C2 node like `nifi.c2.root.class.definitions.mynodes` class for example or requested in the `nifi.c2.root.classes` it may not be so obvious we want to filter for metrics. C2 can support any response node that may or may not be metric nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org