You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/07 23:55:47 UTC
[GitHub] [hadoop-ozone] swagle opened a new pull request #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
swagle opened a new pull request #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418
## What changes were proposed in this pull request?
If readStateMachine call fails there is no way to recover for the follower and hence trigger pipeline close action.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2716
## How was this patch tested?
Added a new end to end integration test to simulate failure and verify pipeline close.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
elek commented on issue #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418#issuecomment-584062457
Hi, what is the state of this PR? Do we need to merge it? @bshashikant ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on issue #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
bshashikant commented on issue #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418#issuecomment-573579499
@swagle , as per discussion with @mukul1987 , let's fix this in Ratis. ReadStateMachine failure should be propagated back to Ratis, and ratis should treat this a log failure and invoke Stamachine#notifyLogFailed() Api which will trigger pipeline close in Ozone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on issue #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
bshashikant commented on issue #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418#issuecomment-572165768
Thanks @swagle for working on this. The changes look good. As @swagle suggested, let's combine marking the stateMachine unhealthy as well as triggering pipeline close together for better clarity of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] swagle commented on issue #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
swagle commented on issue #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418#issuecomment-573807913
> @swagle , as per discussion with @mukul1987 , let's fix this in Ratis. ReadStateMachine failure should be propagated back to Ratis, and ratis should treat this a log failure and invoke Stamachine#notifyLogFailed() Api which will trigger pipeline close in Ozone.
Does that also apply to other places we mark the StateMachine UNHEALTHY? Namely: writeStateMachineData and applyTransaction?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418#issuecomment-588251602
Sorry, I had to revert this, as it caused compilation error on `master`. Some constants used by the test were recently removed in 4ce2796b1 and d497bf683.
As the patch only contains the test and some log level change, I assume the original issue is fixed in Ratis. Please reopen the Jira issue if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant merged pull request #418: HDDS-2716.
ReadStateMachine failure should close down the ratis pipeline
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #418: HDDS-2716. ReadStateMachine failure should close down the ratis pipeline
URL: https://github.com/apache/hadoop-ozone/pull/418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org