You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by ant elder <an...@gmail.com> on 2007/05/02 16:09:43 UTC

Could ServletHostExtension add/removeServletMapping take a URI instead of a host and mapping?

The ServletHostExtension currently uses methods like addServletMapping(int
host, String mapping, Servlet servlet) so in the things that use this like
the Axis2 binding you have to work out things like the host port, eg, see
the Axis2ServiceBinding start and stop methods. Could ServletHostExtension
add/removeServletMapping be changed to just take a URI and a Servlet and
have the ServletHostExtension implementation do the best it can to get the
servlet registered at the URI?

   ...ant

Re: Could ServletHostExtension add/removeServletMapping take a URI instead of a host and mapping?

Posted by ant elder <an...@gmail.com>.
On 5/2/07, Jean-Sebastien Delfino <js...@apache.org> wrote:
>
> ant elder wrote:
> > The ServletHostExtension currently uses methods like
> > addServletMapping(int
> > host, String mapping, Servlet servlet) so in the things that use this
> > like
> > the Axis2 binding you have to work out things like the host port, eg,
> see
> > the Axis2ServiceBinding start and stop methods. Could
> > ServletHostExtension
> > add/removeServletMapping be changed to just take a URI and a Servlet and
> > have the ServletHostExtension implementation do the best it can to get
> > the
> > servlet registered at the URI?
> >
> >   ...ant
> >
>
> Yes, I had come up with the initial signature but what you're proposing
> makes more sense.
>
> I'd suggest to pass a String uri (to not force all callers to create a
> URI object) and do the String/URI parsing inside the ServletHost.


Ok, i'll give that a go.

   ...ant

Re: Could ServletHostExtension add/removeServletMapping take a URI instead of a host and mapping?

Posted by Jean-Sebastien Delfino <js...@apache.org>.
ant elder wrote:
> The ServletHostExtension currently uses methods like 
> addServletMapping(int
> host, String mapping, Servlet servlet) so in the things that use this 
> like
> the Axis2 binding you have to work out things like the host port, eg, see
> the Axis2ServiceBinding start and stop methods. Could 
> ServletHostExtension
> add/removeServletMapping be changed to just take a URI and a Servlet and
> have the ServletHostExtension implementation do the best it can to get 
> the
> servlet registered at the URI?
>
>   ...ant
>

Yes, I had come up with the initial signature but what you're proposing 
makes more sense.

I'd suggest to pass a String uri (to not force all callers to create a 
URI object) and do the String/URI parsing inside the ServletHost.

-- 
Jean-Sebastien


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org