You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 11:28:28 UTC

[GitHub] [incubator-hudi] Trevor-zhang opened a new pull request #1477: [HUDI-749] Fix packaging/hudi-timeline-server-bundle./run_server.sh s…

Trevor-zhang opened a new pull request #1477: [HUDI-749] Fix packaging/hudi-timeline-server-bundle./run_server.sh s…
URL: https://github.com/apache/incubator-hudi/pull/1477
 
 
   …tart error
   
   
   ## What is the purpose of the pull request
   
   Fix packaging/hudi-timeline-server-bundle./run_server.sh s…
   
   ## Brief change log
   
   fix
   
   ## Verify this pull request
   This change can get more accurate information
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

Posted by GitBox <gi...@apache.org>.
Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401647927
 
 

 ##########
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##########
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | grep -v source | head -1`
 
 Review comment:
   > nit:
   > change to
   > HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | grep -v source | head -1` should be ok(just need add `| grep -v source`).
   
   It's my fault! 
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401610086
 
 

 ##########
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##########
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | grep -v source | head -1`
 
 Review comment:
   nit: 
   change to 
   HOODIE_JAR=\`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | grep -v source | head -1\` should be ok(just need add `| grep -v source`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401600700
 
 

 ##########
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##########
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | grep -v source | head -1`
 
 Review comment:
   nit: `ls c` to `ls -c`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf merged pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

Posted by GitBox <gi...@apache.org>.
Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401647133
 
 

 ##########
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##########
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | grep -v source | head -1`
 
 Review comment:
   > nit: `ls c` to `ls -c`
   
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services