You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/16 13:43:08 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12457: [Arith] Parse > and >= bounds in ConstIntBoundAnalyzer
Lunderberg opened a new pull request, #12457:
URL: https://github.com/apache/tvm/pull/12457
Previously, only `<` and `<=` bounds were parsed, as these are the canonical form produced by the `RewriteSimplifier`. However, the constraint may also be supplied by the user through the Python API, and may not be canonicalized prior to parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12457: [Arith] Parse > and >= bounds in ConstIntBoundAnalyzer
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12457:
URL: https://github.com/apache/tvm/pull/12457#issuecomment-1216658002
@tkonolige
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #12457: [Arith] Parse > and >= bounds in ConstIntBoundAnalyzer
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #12457:
URL: https://github.com/apache/tvm/pull/12457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12457: [Arith] Parse > and >= bounds in ConstIntBoundAnalyzer
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12457:
URL: https://github.com/apache/tvm/pull/12457#issuecomment-1216660464
As a comment, this situation can occur by accident in Python when writing `1 <= var`. Because the lhs and rhs have different types, this is resolved as `var.__ge__(1)`, which generates `GE(var, 1)` instead of the desired `LE(1, var)`. While this can be avoided by writing `IntImm(var.dtype, 1) < var`, it isn't immediately obvious to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org