You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2017/09/28 18:43:25 UTC
[GitHub] spark pull request #19384: [SPARK-22159][SQL] Make config names consistently...
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/19384
[SPARK-22159][SQL] Make config names consistently end with "enabled".
## What changes were proposed in this pull request?
spark.sql.execution.arrow.enable and spark.sql.codegen.aggregate.map.twolevel.enable -> enabled
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-22159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19384
----
commit d41e34720073be568053f220946cb01ea2ff61ef
Author: Reynold Xin <rx...@databricks.com>
Date: 2017-09-28T18:42:41Z
[SPARK-22159][SQL] Make config names consistently end with "enabled".
spark.sql.execution.arrow.enable and spark.sql.codegen.aggregate.map.twolevel.enable -> enabled
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82289/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82289/testReport)** for PR 19384 at commit [`8e51ae5`](https://github.com/apache/spark/commit/8e51ae52b6d54ed46a3441bbb83a8e93ba214410).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19384
I reverted the 2nd commit. Should be good for merge now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82286/testReport)** for PR 19384 at commit [`d41e347`](https://github.com/apache/spark/commit/d41e34720073be568053f220946cb01ea2ff61ef).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19384
Thanks! Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82289/testReport)** for PR 19384 at commit [`8e51ae5`](https://github.com/apache/spark/commit/8e51ae52b6d54ed46a3441bbb83a8e93ba214410).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19384
Update the PR title and description?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82286/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19384
hm the 2nd commit is not meant for this one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82297/testReport)** for PR 19384 at commit [`3d82277`](https://github.com/apache/spark/commit/3d82277d3e7a1183f7f4fc9b4e444a66aea4544e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19384: [SPARK-22159][SQL] Make config names consistently...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19384
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82297/testReport)** for PR 19384 at commit [`3d82277`](https://github.com/apache/spark/commit/3d82277d3e7a1183f7f4fc9b4e444a66aea4544e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82297/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19384: [SPARK-22159][SQL] Make config names consistently end wi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19384
**[Test build #82286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82286/testReport)** for PR 19384 at commit [`d41e347`](https://github.com/apache/spark/commit/d41e34720073be568053f220946cb01ea2ff61ef).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org