You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jodersky <gi...@git.apache.org> on 2015/10/15 03:32:58 UTC
[GitHub] spark pull request: [SPARK-11122] Add [warn] tag to fatal warnings
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/9128
[SPARK-11122] Add [warn] tag to fatal warnings
Shows that an error is actually due to a fatal warning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jodersky/spark fatalwarnings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9128
----
commit 245c8a538128c20e6b775d1545016e151707259f
Author: Jakob Odersky <jo...@gmail.com>
Date: 2015-10-15T01:28:25Z
Add [warn] tag to fatal warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148649629
[Test build #1908 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1908/consoleFull) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148549539
sounds like the behavior is the same with only the prefix "[warn] " added for non-deprecation warning, which seems like a good idea...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148678251
[Test build #1910 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1910/consoleFull) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148750210
[Test build #1915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1915/console) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by jodersky <gi...@git.apache.org>.
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148557456
Yeah that's it ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148717522
[Test build #1915 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1915/consoleFull) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148675198
[Test build #1908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1908/console) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by jodersky <gi...@git.apache.org>.
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148438185
In general I agree with you, however since in this case some warnings (such
as deprecations) are not treated as fatal, the user gets a huge amount of
messages and there is no way to distinguish between fatal warnings and
errors. This then can lead to pretty confusing debugging in case of errors.
E.g. I spent an hour trying to reproduce an error that I thought might be
compiler-related, only to find out it was a perfectly valid warning.
As scala 2.10 does not provide any warning-discrimination out-of-the-box, I
can think of a few possibilities to ease debugging:
First, treat all warnings as fatal: show warnings as such then at the end
display a message such as "[error] warnings are treated as fatal". This
option has the inconvenience of also erroring on deprecation warnings and
is thus not acceptable.
Second, don't show deprecation warnings and continue as in the first
option. This hides important information to the user and in my opinion is
not the way to go either.
Third, display all warnings and treat certain ones as errors (as is done
currently) but also inform the user if it was due to a warning. This option
is what I am suggesting in my PR, the user will get an error message with
an additional warn tag: "[error] [warn] blablabla". If you think a
different tag would be more suitable, such as [fatal warn], we can of
course change the message.
I hope this illustrates my idea behind the PR. Let me know what you think
On Oct 15, 2015 4:32 AM, "Sean Owen" <no...@github.com> wrote:
> I think it's OK, but what does it help? if warnings are to be treated as
> errors, they are errors like others. Does it become confusing to log an
> error that says "warn"?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/9128#issuecomment-148360061>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148360061
I think it's OK, but what does it help? if warnings are to be treated as errors, they are errors like others. Does it become confusing to log an error that says "warn"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148760115
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148251261
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11122] [Build] Add [warn] tag to fatal ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9128#issuecomment-148704856
[Test build #1910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1910/console) for PR 9128 at commit [`245c8a5`](https://github.com/apache/spark/commit/245c8a538128c20e6b775d1545016e151707259f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org