[GitHub] [spark] manbuyun commented on a change in pull request #30225: [SPARK-33187][SQL] Add a check on the number of returned partitions in the HiveShim#getPartitionsByFilter method

[GitBox <gi...@apache.org>]

manbuyun commented on a change in pull request #30225:
URL: https://github.com/apache/spark/pull/30225#discussion_r521180717



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -773,26 +773,7 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
     filters.flatMap(convert).mkString(" and ")
   }
 
-  private def quoteStringLiteral(str: String): String = {

Review comment:
       Didn't remove this method, just added the getPartitionsByFilterInternal method




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org