[GitHub] [hadoop] goiri commented on a change in pull request #3595: HDFS-16283: RBF: improve renewLease() to call only a specific NameNod…

[GitBox <gi...@apache.org>]

goiri commented on a change in pull request #3595:
URL: https://github.com/apache/hadoop/pull/3595#discussion_r738674897



##########
File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
##########
@@ -765,6 +765,14 @@ BatchedDirectoryListing getBatchedListing(
   @Idempotent
   void renewLease(String clientName) throws IOException;
 
+  /**
+   * The functionality is the same as renewLease(clientName). This is to support
+   * router based FileSystem to newLease against a specific target FileSystem instead
+   * of all the target FileSystems in each call.
+   */
+  @Idempotent
+  void renewLease(String clientName, String nsId) throws IOException;

Review comment:
       Changing the client protocol requires more than just a RBF PR.
   We should bring this topic up in the mailing list.
   The good news is that this is an additional call and not modifying the existing.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org