[GitHub] [httpcomponents-core] arturobernalg commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

["arturobernalg (via GitHub)" <gi...@apache.org>]

arturobernalg commented on PR #390:
URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1430330009

   > @arturobernalg One more thing. The javadocs say
   > 
   > ```
   >  The Forwarded header is added to the request by calling the `HttpRequest.addHeader` method. If a
   >  Forwarded header already exists in the request, the new key-value pairs are appended to the
   >  existing header.
   > ```
   > 
   > but this is not what the implementation currently does and I think it did not do that before, either. Is the interceptor meant to preserve the list of previous hops in the forwarded chain or it is meant to build the initial list consisting of the first hop only? Please clarify.
   
   @ok2c my mistake. the existing header is overwritten with the newly generated value


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org