You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2018/08/03 16:23:00 UTC

[jira] [Comment Edited] (YARN-8624) Cleanup ENTRYPOINT documentation

    [ https://issues.apache.org/jira/browse/YARN-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568432#comment-16568432 ] 

Eric Yang edited comment on YARN-8624 at 8/3/18 4:22 PM:
---------------------------------------------------------

{code}
If a Docker image has an entry point set, the entry point will be honored, but the default command may be overridden, as just mentioned above. Unless the entry point is something similar to sh -c or YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, the net result will likely be undesirable. Because the YARN container launch script is required to correctly launch the YARN task, use of entry points is discouraged. 
{code}

can be replaced with:

{code}
If a Docker image has an entry point set and YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, launch_command will be passed to ENTRYPOINT program as CMD parameters in Docker.  The format of launch_command looks like: param1,param2, and this translates to CMD [ "param1","param2" ] in Docker.
{code}


was (Author: eyang):
{code}
If a Docker image has an entry point set, the entry point will be honored, but the default command may be overridden, as just mentioned above. Unless the entry point is something similar to sh -c or YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, the net result will likely be undesirable. Because the YARN container launch script is required to correctly launch the YARN task, use of entry points is discouraged. 
{code}

can be replaced with:

{code}
If a Docker image has an entry point set and YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, launch_command will be passed to ENTRYPOINT program as CMD parameters in Docker.  The format of launch_command looks like:
param1,param2, and this translates to CMD [ "param1","param2" ] in Docker.
{code}

> Cleanup ENTRYPOINT documentation
> --------------------------------
>
>                 Key: YARN-8624
>                 URL: https://issues.apache.org/jira/browse/YARN-8624
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Craig Condit
>            Priority: Minor
>              Labels: Docker
>
> With the changes to allow disabling the YARN launch script in favor of running whatever is specified in the image, I think the following needs to be remove/updated. There is already a section called Docker Container ENTRYPOINT support. I think we can clean this up a bit make it easier to understand this feature. Given the need to explain YARN's existing launching logic, this also may be best for a follow on ticket as it will require some testing to fully describe the feature.
> {code:java}
> If a Docker image has a command set, the behavior will depend on whether the YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true. If so, the command will be overridden when LCE launches the image with YARN's container launch script. 
>  If a Docker image has an entry point set, the entry point will be honored, but the default command may be overridden, as just mentioned above. Unless the entry point is something similar to sh -c or YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE is set to true, the net result will likely be undesirable. Because the YARN container launch script is required to correctly launch the YARN task, use of entry points is discouraged. {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org