You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 20:06:16 UTC

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint

willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434145201



##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
         "changed_by_url",
         "changed_by.username",
         "changed_on",
+        "columns.id",
+        "column_count",
         "default_endpoint",
         "explore_url",
+        "kind",
+        "metrics.id",

Review comment:
       Required to join the `metrics` to get a count. I'm looking into a FAB change to make this less hacky.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org