[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4306: Added tests for RealtimeSegmentValidationManager

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4306: Added tests for RealtimeSegmentValidationManager
URL: https://github.com/apache/incubator-pinot/pull/4306#discussion_r292988240
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
 ##########
 @@ -73,6 +73,8 @@
         "controller.validation.frequencyInSeconds";
     private static final String OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS =
         "controller.offline.segment.interval.checker.frequencyInSeconds";
+    private static final String SEGMENT_VALIDATION_INITIAL_DELAY_IN_SECONDS =
 
 Review comment:
   All segment-level validation are done with a single call to get a random back-off. Therefore it makes sense to have a single variable. RealtimeSegemntValidationManager calls getPeriodicTasksInitialDelay(). Do we really want to introduce(even) more configs just for test sake?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org