[jira] [Commented] (TS-4675) header_rewrite hook descriptions are wrong

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415595#comment-15415595 ] 

Leif Hedstrom commented on TS-4675:
-----------------------------------

Oops, #2 above is wrong, READ_RESPONSE_HDR_HOOK is obviously not the same as READ_REQUEST_PRE_REMAP_HOOK. But, READ_REQUEST_PRE_REMAP_HOOK and READ_REQUEST_HDR_HOOK are.

> header_rewrite hook descriptions are wrong
> ------------------------------------------
>
>                 Key: TS-4675
>                 URL: https://issues.apache.org/jira/browse/TS-4675
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Miles Libbey
>            Assignee: Leif Hedstrom
>             Fix For: Docs
>
>
> - REMAP_PSEUDO_HOOK is not similar to READ_RESPONSE_HDR_HOOK. 
> - Think that READ_RESPONSE_HDR_HOOK and READ_REQUEST_PRE_REMAP_HOOK are aliases to each other.  
> ( #define TS_HTTP_READ_REQUEST_PRE_REMAP_HOOK TS_HTTP_PRE_REMAP_HOOK /* backwards compat */)
> - Should note that READ_REQUEST_PRE_REMAP_HOOK/READ_REQUEST_HDR_HOOK can not be applied to remap rules. Just global rules.
> - REMAP_PSEUDO_HOOK doesn't show in https://docs.trafficserver.apache.org/en/latest/developer-guide/plugins/hooks-and-transactions/index.en.html#http-transaction-state-diagram , so don't know when it actually fires.
> - We should present the hooks in order of their firing. Eg, READ_RESPONSE_HDR_HOOK should be after pre_remap...
> - Seems like we should have a diagram similar to https://docs.trafficserver.apache.org/en/latest/developer-guide/plugins/hooks-and-transactions/index.en.html#http-transaction-state-diagram on the page. (With the header_rewrite names, and simplified -- don't need all the gory oval detail.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)