[GitHub] stevedlawrence commented on a change in pull request #29: Fixed bug in calculating bit length for delimited unparsing

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #29: Fixed bug in calculating bit length for delimited unparsing
URL: https://github.com/apache/incubator-daffodil/pull/29#discussion_r163659674
 
 

 ##########
 File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AU.tdml
 ##########
 @@ -7,23 +7,23 @@
     description="Binary values packed and bsd">
     <document>
       <documentPart type="byte"><![CDATA[
-    1700 2300 2700 4119 8c01 8b01 1c72 1b72 7542 636e 2068 666f 4e20 6d75 6562 7372
+    0017 0023 0027 1941 018c 018b 721c 721b 4275 6e63 6820 6f66 204e 756d 6265 7273
     ]]></documentPart>
     </document>
     <infoset>
       <dfdlInfoset>
         <list xmlns="http://www.example.org/example1" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-          <bcd type="xsd:int">0017</bcd>
-          <bcd type="xsd:int">0023</bcd>
-          <bcd type="xsd:int">0027</bcd>
+          <bcd type="xsd:int">17</bcd>
+          <bcd type="xsd:int">23</bcd>
+          <bcd type="xsd:int">27</bcd>
 
 Review comment:
   Should the ``type`` here be xsd:unsignedInt to match your changes above. Daffodil currently ignores this attribute, but we might check it one day.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services