You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by Apache Wiki <wi...@apache.org> on 2013/10/07 22:43:34 UTC

[Cordova Wiki] Update of "ProcessingPullRequests" by MarcelKinard

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cordova Wiki" for change notification.

The "ProcessingPullRequests" page has been changed by MarcelKinard:
https://wiki.apache.org/cordova/ProcessingPullRequests?action=diff&rev1=2&rev2=3

Comment:
add verbage about branches

   * If it is not there, direct them to [[http://www.apache.org/licenses/#clas]]
  
  === Step 3: Merge the change ===
- Run the following:
+ Run the following as an exemplary way to merge to master:
  {{{#!sh
  # REPO_NAME example: "js"
  # PULL_REQUEST_NUMBER example: "44"
@@ -31, +31 @@

   * Squash as many commits as is reasonable together.
   * Re-write commit messages to include JIRA issue numbers in the form [CB-####]
  
+ Be aware that not all repos use "master" as the active development branch. See "Which Branch to Commit To" in [[http://wiki.apache.org/cordova/CommitterWorkflow|Committer Workflow]].
  
  === Step 4: Check the author ===
  
@@ -72, +73 @@

     * The "Fix Version" field is used for the purpose of Release Notes, and should be set to the [[VersioningAndReleaseStrategy|CadVer]]
  
  === Step 8: Final details ===
-  * Respond to pull request on github with link to their commit and ask them to close the pull request.
+  * Respond to pull request on github with link to their commit you just performed and ask them to close the pull request. The instructions for closing a pull request are in the [[https://wiki.apache.org/cordova/ContributorWorkflow|Contributor Workflow]] in the section titled "When Your Pull Request is Accepted".