You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/06/29 12:36:34 UTC
[shardingsphere] branch master updated: Improve migration commit, make sure stop job before drop (#26692)
This is an automated email from the ASF dual-hosted git repository.
zhonghongsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 9c6e04882ce Improve migration commit, make sure stop job before drop (#26692)
9c6e04882ce is described below
commit 9c6e04882cef91a6f5fe3d2cf571a8e6152b800f
Author: Xinze Guo <10...@users.noreply.github.com>
AuthorDate: Thu Jun 29 20:36:26 2023 +0800
Improve migration commit, make sure stop job before drop (#26692)
---
.../data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java
index aa42d2e4fab..52e745047eb 100644
--- a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java
+++ b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java
@@ -421,8 +421,8 @@ public final class MigrationJobAPI extends AbstractInventoryIncrementalJobAPIImp
public void commit(final String jobId) {
log.info("Commit job {}", jobId);
final long startTimeMillis = System.currentTimeMillis();
- dropCheckJobs(jobId);
stop(jobId);
+ dropCheckJobs(jobId);
MigrationJobConfiguration jobConfig = getJobConfiguration(jobId);
refreshTableMetadata(jobId, jobConfig.getTargetDatabaseName());
dropJob(jobId);