You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by manuzhang <gi...@git.apache.org> on 2016/09/02 00:54:58 UTC

[GitHub] storm pull request #1648: STORM-2054 DependencyResolver should be aware of r...

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1648#discussion_r77279412
  
    --- Diff: external/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java ---
    @@ -37,16 +37,19 @@ public static RepositorySystemSession newRepositorySystemSession(
                 RepositorySystem system, String localRepoPath) {
             MavenRepositorySystemSession session = new MavenRepositorySystemSession();
     
    -        // find homedir
    -        String home = System.getProperty("storm.home");
    -        if (home == null) {
    -            home = ".";
    -        }
    +        File repoDir = new File(localRepoPath);
    --- End diff --
    
    Why not leave the handling of path to the caller of `Booter` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---