[GitHub] [accumulo] cshannon commented on a diff in pull request #3332: WIP - Add an optional fenced range to Tablet files

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3332:
URL: https://github.com/apache/accumulo/pull/3332#discussion_r1181878173


##########
server/base/src/main/java/org/apache/accumulo/server/fs/FileManager.java:
##########
@@ -244,8 +244,9 @@ private List<String> takeOpenFiles(Collection<String> files,
     return filesToOpen;
   }
 
-  private Map<FileSKVIterator,String> reserveReaders(KeyExtent tablet, Collection<String> files,
-      boolean continueOnFailure, CacheProvider cacheProvider) throws IOException {
+  private Map<FileSKVIterator,TabletFile> reserveReaders(KeyExtent tablet,
+      Collection<TabletFile> files, boolean continueOnFailure, CacheProvider cacheProvider)
+      throws IOException {
 
     if (!tablet.isMeta() && files.size() >= maxOpen) {

Review Comment:
   I would think that in this case we could just track open files by the actual file and not use the ranges. It would make sense to me that you'd only care about real files that were open in HDFS so if you had several files that were the same but different ranges we would just count it as 1 and then this wouldn't be an issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org