You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/01 04:45:25 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #17791: [BEAM-13590]Update Pytest version to support Python 3.10
AnandInguva opened a new pull request, #17791:
URL: https://github.com/apache/beam/pull/17791
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #17791:
URL: https://github.com/apache/beam/pull/17791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1159299389
# [Codecov](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17791](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4ba8d8) into [master](https://codecov.io/gh/apache/beam/commit/9a6f7699b5d8daf846221d522d3702c5a4c7b562?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a6f769) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17791 +/- ##
==========================================
- Coverage 74.02% 73.95% -0.07%
==========================================
Files 695 700 +5
Lines 91872 92526 +654
==========================================
+ Hits 68007 68428 +421
- Misses 22619 22852 +233
Partials 1246 1246
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.57% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache\_beam/runners/dataflow/dataflow\_job\_service.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19qb2Jfc2VydmljZS5weQ==) | `50.00% <0.00%> (-12.17%)` | :arrow_down: |
| [...s/interactive/dataproc/dataproc\_cluster\_manager.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kYXRhcHJvYy9kYXRhcHJvY19jbHVzdGVyX21hbmFnZXIucHk=) | `77.41% <0.00%> (-6.80%)` | :arrow_down: |
| [...eam/transforms/py\_dataflow\_distribution\_counter.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9weV9kYXRhZmxvd19kaXN0cmlidXRpb25fY291bnRlci5weQ==) | `91.42% <0.00%> (-4.87%)` | :arrow_down: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [.../apache\_beam/runners/interactive/dataproc/types.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kYXRhcHJvYy90eXBlcy5weQ==) | `96.55% <0.00%> (-3.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/io.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2lvLnB5) | `88.78% <0.00%> (-3.26%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `87.51% <0.00%> (-2.50%)` | :arrow_down: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `77.89% <0.00%> (-1.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.01% <0.00%> (-1.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/counters.py](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvY291bnRlcnMucHk=) | `85.39% <0.00%> (-1.36%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/beam/pull/17791/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a6f769...d4ba8d8](https://codecov.io/gh/apache/beam/pull/17791?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1159314442
> Took a quick look. please investigate if this is related to this change.
>
> ```
> 18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
> 18:27:31
> 18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
> 18:27:31
> 18:27:31 FAILURE: Build failed with an exception.
> 18:27:31
> 18:27:31 * What went wrong:
> 18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
> 18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
> 18:27:31
> 18:27:31 * Try:
> 18:27:31 > Run with --stacktrace option to get the stack trace.
> 18:27:31 > Run with --info or --debug option to get more log output.
> 18:27:31 > Run with --scan to get full insights.
> 18:27:31
> 18:27:31 * Get more help at https://help.gradle.org/
> 18:27:31
> 18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
> ```
I looked into it. pytest-cov needs to be updated as well because of https://github.com/pytest-dev/pytest-cov/pull/412. Now everything passes.
PTAL @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1143988518
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1147595271
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1147832510
> Took a quick look. please investigate if this is related to this change.
>
> ```
> 18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
> 18:27:31
> 18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
> 18:27:31
> 18:27:31 FAILURE: Build failed with an exception.
> 18:27:31
> 18:27:31 * What went wrong:
> 18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
> 18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
> 18:27:31
> 18:27:31 * Try:
> 18:27:31 > Run with --stacktrace option to get the stack trace.
> 18:27:31 > Run with --info or --debug option to get more log output.
> 18:27:31 > Run with --scan to get full insights.
> 18:27:31
> 18:27:31 * Get more help at https://help.gradle.org/
> 18:27:31
> 18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
> ```
Yes. I will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1143112131
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1143988662
Run Python 3.8 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1143120908
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1147752095
Took a quick look. need to investigate if this is related to our change.
```
18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
18:27:31
18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
18:27:31
18:27:31 FAILURE: Build failed with an exception.
18:27:31
18:27:31 * What went wrong:
18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
18:27:31
18:27:31 * Try:
18:27:31 > Run with --stacktrace option to get the stack trace.
18:27:31 > Run with --info or --debug option to get more log output.
18:27:31 > Run with --scan to get full insights.
18:27:31
18:27:31 * Get more help at https://help.gradle.org/
18:27:31
18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1159241036
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17791: [BEAM-13590]Update Pytest version to support Python 3.10
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17791:
URL: https://github.com/apache/beam/pull/17791#issuecomment-1143112132
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org